Make DependencyInjection more linker trimmable #38729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the unused ServiceProviderEngine strategy types to be trimmed by the ILLinker. Fix dotnet#38678
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
pakrym
approved these changes
Jul 2, 2020
maryamariyan
approved these changes
Jul 2, 2020
maryamariyan
reviewed
Jul 2, 2020
.../Microsoft.Extensions.DependencyInjection/src/ServiceCollectionContainerBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
eerhardt
force-pushed
the
DependencyInjectionTrimmable
branch
from
631a92e to
faaee83
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the unused ServiceProviderEngine strategy types to be trimmed by the ILLinker by removing the
ServiceProviderModeenum and only have the "default" behavior in the product. TheServiceProviderModeenum is only used for testing, so move it to the tests.Fix #38678
This allows for System.Linq.Expressions to be completely removed in a default Blazor application. It also removes one of two usages of System.Reflection.Emit (the other being #38693).
With this change, the IL size of a Blazor WASM default template application: