[CBOR] Use System.Half for encoding and decoding half-precision data items #38466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
reviewed
Jun 26, 2020
src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Reader/CborReader.Simple.cs
Show resolved
Hide resolved
| // Remove class once https://github.com/dotnet/runtime/issues/38288 has been addressed | ||
| internal static class HalfHelpers | ||
| { | ||
| public const int SizeOfHalf = sizeof(short); |
There was a problem hiding this comment.
Why not just use sizeof(Half) inline where needed?
There was a problem hiding this comment.
Compiler complains that it doesn't have a predefined size, so would have to mark as unsafe. Presumably because it's a new type?
| if (!CborConformanceModeHelpers.RequiresPreservingFloatPrecision(ConformanceMode) && | ||
| FloatSerializationHelpers.TryConvertSingleToHalf(value, out Half half)) | ||
| { | ||
| WriteHalf(half); |
There was a problem hiding this comment.
Why WriteHalf vs WriteSingleCore and WriteDoubleCore?
There was a problem hiding this comment.
The Write[Float]Core methods implement serialization for the particular precision without doing conformance mode checks and potential downsizing. WriteHalf doesn't need downsizing since it's the smallest type. Perhaps calling it something like WriteSingleNoDownsizing might reduce confusion?
bartonjs
approved these changes
Jun 29, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#nullabledirectives which are no longer required.The implementation also adds a reader and writer method for System.Half which are currently marked internal. I will follow up with an API proposal for these.