Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable native varargs for Windows arm #38147

Merged
merged 6 commits into from
Jun 19, 2020

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Jun 19, 2020

Disable native varargs for Windows arm so ArgsIterator throws PlatformNotSupported exception. Also re-enable the test that was disabled in #35690.

Fixes: #35754

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label.

@kunalspathak kunalspathak marked this pull request as ready for review June 19, 2020 20:52
@kunalspathak
Copy link
Member Author

Manually triggered runtime pipeline and leg "Libraries Test Run release coreclr Windows_NT arm Release" passed.
Merging because the last commit is formatting.

@kunalspathak kunalspathak merged commit 7d5dd34 into dotnet:master Jun 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgIteratorTests.ArgIterator_Throws_PlatformNotSupportedException test fails on Windows ARM
3 participants