Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce use of TRACE_VERBOSE in SslStream #37917

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jun 15, 2020

Per comment in #37888, this removes some, now obsolete, TRACE_VERBOSE.
It either uses NetEventSource.Verbose or drops the message when I felt the value would be low.

@wfurt wfurt added enhancement Product code improvement that does NOT require public API changes/additions area-System.Net.Security labels Jun 15, 2020
@wfurt wfurt requested review from davidsh and a team June 15, 2020 18:58
@wfurt wfurt self-assigned this Jun 15, 2020
@ghost
Copy link

ghost commented Jun 15, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@davidsh davidsh added this to the 5.0 milestone Jun 15, 2020
@wfurt
Copy link
Member Author

wfurt commented Jun 16, 2020

Installer on OSX seems infrastructure issue #34472.

@wfurt wfurt merged commit fb39507 into dotnet:master Jun 16, 2020
@wfurt wfurt deleted the verboseSsl branch June 16, 2020 22:44
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants