[Arm64] ASIMD By Element Intrinsics #36916
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1461,7 +1461,7 @@ bool GenTree::Compare(GenTree* op1, GenTree* op2, bool swapOK) | |
| if ((op1->AsHWIntrinsic()->gtHWIntrinsicId != op2->AsHWIntrinsic()->gtHWIntrinsicId) || | ||
| (op1->AsHWIntrinsic()->gtSIMDBaseType != op2->AsHWIntrinsic()->gtSIMDBaseType) || | ||
| (op1->AsHWIntrinsic()->gtSIMDSize != op2->AsHWIntrinsic()->gtSIMDSize) || | ||
| (op1->AsHWIntrinsic()->GetAuxiliaryType() != op2->AsHWIntrinsic()->GetAuxiliaryType())) | ||
| { | ||
| return false; | ||
| } | ||
|
|
@@ -2131,7 +2131,7 @@ unsigned Compiler::gtHashValue(GenTree* tree) | |
| hash += tree->AsHWIntrinsic()->gtHWIntrinsicId; | ||
| hash += tree->AsHWIntrinsic()->gtSIMDBaseType; | ||
| hash += tree->AsHWIntrinsic()->gtSIMDSize; | ||
| hash += tree->AsHWIntrinsic()->GetAuxiliaryType(); | ||
| break; | ||
| #endif // FEATURE_HW_INTRINSICS | ||
|
|
||
|
|
@@ -7478,7 +7478,7 @@ GenTree* Compiler::gtCloneExpr( | |
| GenTreeHWIntrinsic(hwintrinsicOp->TypeGet(), hwintrinsicOp->gtGetOp1(), | ||
| hwintrinsicOp->gtGetOp2IfPresent(), hwintrinsicOp->gtHWIntrinsicId, | ||
| hwintrinsicOp->gtSIMDBaseType, hwintrinsicOp->gtSIMDSize); | ||
| copy->AsHWIntrinsic()->SetAuxiliaryType(hwintrinsicOp->GetAuxiliaryType()); | ||
| } | ||
| break; | ||
| #endif | ||
|
|
@@ -18661,13 +18661,13 @@ GenTreeHWIntrinsic* Compiler::gtNewScalarHWIntrinsicNode( | |
| // Returns true for the HW Instrinsic instructions that have MemoryLoad semantics, false otherwise | ||
| bool GenTreeHWIntrinsic::OperIsMemoryLoad() const | ||
| { | ||
| #if defined(TARGET_XARCH) || defined(TARGET_ARM64) | ||
| HWIntrinsicCategory category = HWIntrinsicInfo::lookupCategory(gtHWIntrinsicId); | ||
| if (category == HW_Category_MemoryLoad) | ||
| { | ||
| return true; | ||
| } | ||
| #ifdef TARGET_XARCH | ||
| else if (HWIntrinsicInfo::MaybeMemoryLoad(gtHWIntrinsicId)) | ||
| { | ||
| // Some intrinsics (without HW_Category_MemoryLoad) also have MemoryLoad semantics | ||
|
|
@@ -18697,19 +18697,20 @@ bool GenTreeHWIntrinsic::OperIsMemoryLoad() const | |
| } | ||
| } | ||
| #endif // TARGET_XARCH | ||
| #endif // TARGET_XARCH || TARGET_ARM64 | ||
| return false; | ||
| } | ||
|
|
||
| // Returns true for the HW Instrinsic instructions that have MemoryStore semantics, false otherwise | ||
| bool GenTreeHWIntrinsic::OperIsMemoryStore() const | ||
| { | ||
| #if defined(TARGET_XARCH) || defined(TARGET_ARM64) | ||
| HWIntrinsicCategory category = HWIntrinsicInfo::lookupCategory(gtHWIntrinsicId); | ||
| if (category == HW_Category_MemoryStore) | ||
| { | ||
| return true; | ||
| } | ||
| #ifdef TARGET_XARCH | ||
| else if (HWIntrinsicInfo::MaybeMemoryStore(gtHWIntrinsicId) && | ||
| (category == HW_Category_IMM || category == HW_Category_Scalar)) | ||
| { | ||
|
|
@@ -18732,13 +18733,14 @@ bool GenTreeHWIntrinsic::OperIsMemoryStore() const | |
| } | ||
| } | ||
| #endif // TARGET_XARCH | ||
| #endif // TARGET_XARCH || TARGET_ARM64 | ||
| return false; | ||
| } | ||
|
|
||
| // Returns true for the HW Instrinsic instructions that have MemoryLoad semantics, false otherwise | ||
| bool GenTreeHWIntrinsic::OperIsMemoryLoadOrStore() const | ||
| { | ||
| #if defined(TARGET_XARCH) || defined(TARGET_ARM64) | ||
| return OperIsMemoryLoad() || OperIsMemoryStore(); | ||
| #else | ||
| return false; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4728,8 +4728,8 @@ struct GenTreeJitIntrinsic : public GenTreeOp | |
| ClassLayout* m_layout; | ||
|
|
||
| union { | ||
| var_types gtAuxiliaryType; // For intrinsics than need another type (e.g. Avx2.Gather* or SIMD (by element)) | ||
|
There was a problem hiding this comment. Why rename to There was a problem hiding this comment. Since I didn't touch gtOtherReg in other files. The intent of the renaming was to get rid of BaseType since for SIMD By Element intrinsics I use this field to encode a SIMD type of an indexed element while in some other case we do use it to keep the "other" base type (e.g. in case of wide/long intrinsics). I could've renamed it to gtOtherType. Do you want me to rename the gtOtherReg -> gtAuxiliaryReg? There was a problem hiding this comment. Was mostly just interested. This makes sense, thanks! There was a problem hiding this comment. I like the renaming. I think it's reasonable to keep the reg as |
||
| regNumberSmall gtOtherReg; // For intrinsics that return 2 registers | ||
| }; | ||
|
|
||
| public: | ||
|
|
@@ -4766,14 +4766,14 @@ struct GenTreeJitIntrinsic : public GenTreeOp | |
| assert(gtOtherReg == reg); | ||
| } | ||
|
|
||
| var_types GetAuxiliaryType() const | ||
| { | ||
| return gtAuxiliaryType; | ||
| } | ||
|
|
||
| void SetAuxiliaryType(var_types type) | ||
| { | ||
| gtAuxiliaryType = type; | ||
| } | ||
|
|
||
| GenTreeJitIntrinsic(genTreeOps oper, var_types type, GenTree* op1, GenTree* op2, var_types baseType, unsigned size) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's minor, but thanks for renaming this - even if/when it was the last op, semantically it's more important that it's an immediate.