Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PlatformAbstractions from runtime tests. #36243

Merged
merged 2 commits into from
May 12, 2020
Merged

Remove PlatformAbstractions from runtime tests. #36243

merged 2 commits into from
May 12, 2020

Conversation

eerhardt
Copy link
Member

Contributes to #3470

@ghost
Copy link

ghost commented May 11, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

tarekgh
tarekgh approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of questions, other than that LGTM.

@jaredpar jaredpar mentioned this pull request May 11, 2020
Closed
ViktorHofer
ViktorHofer approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@eerhardt eerhardt force-pushed the RemovePlatformAbstractionsFromTests branch from 6504a43 to aa91318 Compare May 12, 2020 15:34
@eerhardt
Copy link
Member Author

The allConfigurations failure is #36285.

@eerhardt eerhardt merged commit 7fb42d9 into dotnet:master May 12, 2020
@eerhardt eerhardt deleted the RemovePlatformAbstractionsFromTests branch May 12, 2020 20:09
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@safern safern safern approved these changes

@stephentoub stephentoub stephentoub approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eerhardt @stephentoub @ViktorHofer @tarekgh @safern @Dotnet-GitSync-Bot