Apply CA1835 - Prefer memory overloads for Stream.ReadAsync/WriteAsync #35941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
stephentoub,
buyaa-n,
bartonjs,
jeffhandley and
pgovind
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImplAsync.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImplAsync.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.Parse.cs
Outdated
Show resolved
Hide resolved
layomia
reviewed
May 7, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.Parse.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.Parse.cs
Outdated
Show resolved
Hide resolved
|
The unit tests for |
buyaa-n
reviewed
May 8, 2020
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlEncodedRawTextWriterAsync.cs
Show resolved
Hide resolved
buyaa-n
reviewed
May 8, 2020
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlUtf8RawTextWriterAsync.cs
Show resolved
Hide resolved
- Prefer the Stream.ReadAsync and Stream.WriteAsync memory overloads. - Unit test fix suggested by buyaa-n to adjust the usage of these overloads.
carlossanlop
force-pushed
the
RoslynStreamAsync
branch
from
02cd0d9 to
c751ed4
Compare
|
@buyaa-n the unit tests passed with your suggested additions. Thanks for your help. I'll merge this now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CA1835 Roslyn analyzer/fixer has been merged to dotnet/roslyn-analyzers and now the rule needs to be applied in dotnet/runtime.