Disable tests failing apparently due to coverage outage regressions #35860
Conversation
Some tests are configured to run on a targets with specific charecteristics. Use issues.targets to conditionally disable tests not intended to run on all targets.
This reverts commit 1f5abc3.
|
Hmm, the issues.targets bloat looks somewhat worrisome to me; I've always thought that issues.targets should cater for "fixable bugs" (regressions, features soon to be implemented or not yet 100% functional etc.) as opposed to "known limitations" that should be ideally expressed in the project files. Why can't we just state that a particular test is |
|
I had suggested it as a location for now then we could clean it up later. However, as the change is it is a huge amount of specific include/excludes that seems like they are easy to miss. |
There are a lot of "known limitations" in the current issues. For instance vararg tests.
I believe it could be possible, but the urgency around #35783 made it so this was the best short term solution. I am happy to get this where we want when we have less urgency.
If they are not listed they will currently fail in test runs. |
|
For what it is worth I used a bash script to generate the excludes. So it was fairly easy to make exhaustive for the current tip at the time... |
There was a problem hiding this comment.
As I mentioned in Teams, I think this is fine to unblock the current situation but I believe it shouldn't stay that way forever. Longer term, I believe we should strive to make a clear distinction between "fixable bugs" (regressions, remaining bugs in new features) - that's what I believe "issues.targets" is for. If COM tests don't work on Linux or some Intel intrinsic tests don't work on ARM64, that sounds like "known limitations" to me and we should be tagging these somehow in the test projects, not in "issues.targets". That doesn't say such limitations must be set in stone - maybe one day there's going to be COM on Linux - but such a thing is not about "triaging and fixing bugs", it's about making design decisions. With this reservation I'm approving the change as a short-term measure to consolidate our builds.
|
Fixed in another PR... |
ghost
locked as resolved and limited conversation to collaborators
The first 2 patches are part of #35783. This is intended to merge after that patch.