Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S.S.C.Algorithms: Fix duplicate theories warning #35810

Merged
merged 1 commit into from
May 5, 2020

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented May 4, 2020

xunit warning:

Skipping test case with duplicate ID '658dd5afec16f3397ac5ef6b298eb8b71ae5a86f' ('System.Security.Cryptography.Hashing.Algorithms.Tests.BlockSizeValueTests.BlockSizeValueTest(hmacBlockSizeValue: 64, expectedBlockSizeValue: 64)' and 'System.Security.Cryptography.Hashing.Algorithms.Tests.BlockSizeValueTests.BlockSizeValueTest(hmacBlockSizeValue: 64, expectedBlockSizeValue: 64)')

Since different HMAC algorithms have the same block size, the test cases was being folded down in to [64, 64], [128, 128].

Simplest change is to just break them in to individual facts. I don't anticipate new algorithms would be added frequently here.

This seems like a genuinely useful warning from xunit, so I don't expect we'd want to get in the habit of ignoring these.

@ghost
Copy link

ghost commented May 4, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@vcsjones
Copy link
Member Author

vcsjones commented May 4, 2020

Hit #35753

@bartonjs bartonjs merged commit c72c6a3 into dotnet:master May 5, 2020
@vcsjones vcsjones deleted the fix-dup-theories-warning branch May 5, 2020 15:20
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants