Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create duplicate ZeroInits #35585

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Don't create duplicate ZeroInits #35585

merged 1 commit into from
Apr 29, 2020

Conversation

CarolEidt
Copy link
Contributor

No description provided.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 28, 2020
@CarolEidt CarolEidt mentioned this pull request Apr 28, 2020
Closed
@AndyAyersMS
Copy link
Member

If you like, I'll launch the jit-expermential pipleine onthis to see if there are any EH Write Thru tests still failing.

@CarolEidt
Copy link
Contributor Author

If you like, I'll launch the jit-expermential pipleine onthis to see if there are any EH Write Thru tests still failing.

I think I should rebase on master to pick up your other fix?

@CarolEidt
Copy link
Contributor Author

OK, I've rebased (should have done that before).

@AndyAyersMS
Copy link
Member

I think I should rebase on master to pick up your other fix?

Right, the manually launched pipelines run exactly what's on the PR branch. Will launch the other testing shortly.

@AndyAyersMS
Copy link
Member

Down from ~320 failures to ~34 with EH Write Thru enabled. All of the failures look like unexpected null reference exceptions.

@CarolEidt
Copy link
Contributor Author

@dotnet/jit-contrib PTAL

AndyAyersMS
AndyAyersMS approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@CarolEidt CarolEidt merged commit ee3ee42 into dotnet:master Apr 29, 2020
@CarolEidt CarolEidt deleted the FixDoubleZeroInit branch November 19, 2020 19:13
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarolEidt @AndyAyersMS @Dotnet-GitSync-Bot