Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small install_clr issue that creates 'in' folder in output path #34979

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Apr 15, 2020

I've noticed the directory always ends up having a artifacts/bin/coreclr/.../in and artifacts/bin/coreclr/.../sharedFramework/in folders. This fixes that.

@ghost
Copy link

ghost commented Apr 15, 2020

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this!

@hoyosjs hoyosjs changed the title Fix small install_clr issue Fix small install_clr issue that creates 'in' folder in output path Apr 15, 2020
@hoyosjs hoyosjs merged commit a2527e9 into master Apr 16, 2020
@hoyosjs hoyosjs deleted the juhoyosa/small-installation-fix branch April 16, 2020 03:03
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants