Revert "Switch reverse PInvoke to the NativeCallable plan (#34251)" #34306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 4e30ff0.
|
Trigger libraries tests on this to make sure that it is really fixing the failures? |
Sure. I ran them locally 15 times it didn't fail, but let me include a Libraries change here. |
safern
force-pushed
the
RevertReversePInvoke
branch
from
e3abfa2
to
ebeeff5
Compare
|
All tests were green I've removed the commit to trigger libraries tests. I'll go ahead and merge. |
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
Apr 1, 2020
…tnet#34251)" (dotnet#34306)" This reverts commit 94c4b52.
jkotas
added a commit
that referenced
this pull request
Apr 1, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #28553
See: #28553 (comment) for details
cc: @jkotas