Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all PlatformHandlerTest_Cookies_Http2 for WinHttpHandler. #34119

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Disable all PlatformHandlerTest_Cookies_Http2 for WinHttpHandler. #34119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c16d05
Disable all PlatformHandlerTest_Cookies_Http2 for WinHttpHandler.
ManickaP Mar 26, 2020
97e12eb
Added ActiveIssue note.
ManickaP Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
[MemberData(nameof(CookieNamesValuesAndUseCookies))]
public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
{
if (UseVersion.Major == 2)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/33930")]
return;
}

await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
{
HttpClientHandler handler = CreateHttpClientHandler();
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,15 @@ public PlatformHandler_HttpClientHandler_Authentication_Test(ITestOutputHelper o
}

#if NETCOREAPP
#if !WINHTTPHANDLER_TEST // [ActiveIssue("https://github.com/dotnet/runtime/issues/33930")]
[ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows10Version1607OrGreater))]
public sealed class PlatformHandlerTest_Cookies_Http2 : HttpClientHandlerTest_Cookies
{
protected override Version UseVersion => HttpVersion20.Value;

public PlatformHandlerTest_Cookies_Http2(ITestOutputHelper output) : base(output) { }
}
#endif

public sealed class PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test : HttpClientHandler_Asynchrony_Test
{
Expand Down