Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the IL verifier for now, it can't handle code compiled without /features:peverify-compat #33478

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

monojenkins
Copy link
Contributor

!! This PR is a copy of mono/mono#19144, please do not edit or review it in this repo !!
Do not automatically approve this PR:

* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.

!! Merge the PR only after the original PR is merged !!



See mono/mono#18572 (comment).

Fixes mono/mono#18572.

@akoeplinger akoeplinger changed the title Avoid passing /features:peverify-compat to csc, it generates very inefficient code in some cases. Disable the IL verifier for now, it can't handle code compiled without /features:peverify-compat Mar 11, 2020
@akoeplinger akoeplinger marked this pull request as ready for review March 11, 2020 18:44
@akoeplinger akoeplinger merged commit 5ea5b57 into dotnet:master Mar 11, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression since Switch to CharUnicodeInfo from corefx
4 participants