Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package libcoreclrtraceptprovider.so with sharedFramework #32949

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Feb 28, 2020

libcoreclrtraceptprovider.so was being dropped from the latest SDK drops because it wasn't being put into sharedFramework directory.

@sywhang sywhang requested a review from hoyosjs February 28, 2020 01:01
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost
Copy link

ghost commented Feb 28, 2020

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@hoyosjs
Copy link
Member

hoyosjs commented Feb 28, 2020

This is #1282 (and even if it wasn't the time out, #32951 will block this). Merging.

@hoyosjs hoyosjs merged commit 4978c94 into dotnet:master Feb 28, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants