Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VS2019 Preview for libraries build which contains a newer CMake #32626

Merged
merged 9 commits into from
Feb 26, 2020

Conversation

safern
Copy link
Member

@safern safern commented Feb 20, 2020

Fixes: #31888

This re-enable warnaserror on Windows as it was before.

The reason why I just updated it for Libraries is because coreclr was failing because of the newer Windows SDK when building the tests. It seems like the toolset changed so I’ll follow up with @MattGal and when I’m back update to use the same pool and toolset for the whole repo. Also because of that I can’t enable warnaserror in the live local CI build but we get enough coverage with the regular CI build with this change now.

cc: @dotnet/runtime-infrastructure @stephentoub

Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the idea of leaving it around as a switch so you can turn it off and on. I almost wonder if you should add the switch to coreclr and start it as off?

@stephentoub
Copy link
Member

stephentoub commented Feb 21, 2020

Thanks for getting us back to a good state, @safern (or, at least a better one).

@safern
Copy link
Member Author

safern commented Feb 21, 2020

Perf job is failing. Need to take a look at what’s going on and I’ll update the PR before merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official build and CI builds failed with CMake Warning due to build agents updated VS
4 participants