Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check return code of bootstrap script in format.py. #32581

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

erozenfeld
Copy link
Member

Formatting jobs run format.py script, which calls bootstrap.{cmd/sh}
from jitutils. This change adds a check for return code of the call and
returns an error code from format.py if bootstrap.{cmd/sh} failed.

Formatting jobs run format.py script, which calls bootstrap.{cmd/sh}
from jitutils. This change adds a check for return code of the call and
returns an error code from format.py if bootstrap.{cmd/sh} failed.
@erozenfeld
Copy link
Member Author

@ViktorHofer @safern @dotnet/jit-contrib

@erozenfeld
Copy link
Member Author

This prevents confusing errors as in https://dnceng.visualstudio.com/public/_build/results?buildId=526104&view=logs where bootstrap command failed but format.py continued and ended up using a wrong version of clang-format, which reported formatting errors.

@trylek trylek merged commit cf43585 into dotnet:master Feb 20, 2020
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eugene!

@ViktorHofer
Copy link
Member

Something went wrong with clang-format download.

Is there a way to harden that path, by adding retries? Also as we are already there, should we switch jitutils to produce nuget package going forward and take part of the dependency flow system going forward instead of downloading from github directly?

@BruceForstall
Copy link
Member

Is there a way to harden that path, by adding retries?

It wouldn't hurt.

Also as we are already there, should we switch jitutils to produce nuget package going forward and take part of the dependency flow system going forward instead of downloading from github directly?

We've had some discussions about doing this. E.g., a PR to convert jitutils to use Arcade to give us the ability to produce packages. dotnet/jitutils#219 and dotnet/jitutils#208. It hasn't been a high enough priority, though.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants