-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable crossgen tests #32330
Enable crossgen tests #32330
Conversation
/azp run dotnet-runtime-perf |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp help |
Supported commands
See additional documentation. |
/azp list |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run dotnet-runtime-perf |
Azure Pipelines successfully started running 1 pipeline(s). |
This turns on benchmarking for a few binaries to track crossgen.
137daba
to
d236917
Compare
This PR does some support work that is necessary when the PR from arcade comes in which will enable the tests, so it has to go first. I'd like to get this merged ASAP and then put the PR in arcade which in theory will flow in tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with this code, so I can't comment much on it. Hopefully you can test if it works before merging? Or do you need to wait for arcade changes to come in first?
Good question. Before I force pushed and cleaned it up I had the change that's going into arcade in this PR. Here's output from the last CI run showing it worked:
(It only ran one iteration beacuse it wasn't set to upload to the lab. It will run 5 normally.) |
cc @briansull |
Merging as the perf legs are passed and that's the only thing impacted by this change. |
This turns on benchmarking for a few binaries to track crossgen.