Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve call counting mechanism #32250

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Improve call counting mechanism #32250

merged 3 commits into from
Mar 3, 2020

Commits on Mar 2, 2020

  1. Improve call counting mechanism 

    - Commit 1
  - Reverts commit f954c6b, which reverted PR dotnet#1457 due to issues
- Commit 2
  - Fixes crashes and assertion failures seen by the original change, fixes dotnet#29934
  - The crashes were caused by commit dotnet@6aa3c70 in the original PR
  - Call counting infos cannot be deleted when the corresponding call counting stubs may still run, because:
    - The remaining call count decremented by the stub is in the call counting info
    - The only way to get a code version / method desc from a stub is to go through the call counting info
  - Got one repro of the assertion failure in dotnet#22786 and it is most likely caused by the same issue, following heap corruption from modifying a deleted call counting info where the memory is reused for a `NativeCodeVersionNode`, messing up the method desc pointer
  - Fixed with a partial revert of the above commit. Added back the `Complete` stage and then call counting infos are deleted only after it's ensured that call counting stubs won't be used (shortly before deleting them).
- Commit 3
  - Public static functions of `CallCountingManager` that may be called through the debugger may occur before static initialization, added a check for null as suggested in dotnet#29892
    @kouvel
    kouvel committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    d27a377 View commit details
    Browse the repository at this point in the history

  2. Fix crashes and assertion failures seen by the original change

    @kouvel
    kouvel committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    2032c7e View commit details
    Browse the repository at this point in the history

  3. Add check for null for some functions callable from the debugger

    @kouvel
    kouvel committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    ca19f1c View commit details
    Browse the repository at this point in the history