Annotate System.IO.FileSystem.AccessControl for nullable #31780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
commented
Feb 5, 2020
...s/System.IO.FileSystem.AccessControl/src/System/Security/AccessControl/FileSystemSecurity.cs
Outdated
Show resolved
Hide resolved
You need to. If you don't, anyone consuming these APIs will see them as oblivious. |
stephentoub
reviewed
Feb 6, 2020
src/libraries/System.IO.FileSystem.AccessControl/src/System.IO.FileSystem.AccessControl.csproj
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2339
Most of the files were already annotated. There were no update in ref assembly, so didn't enabled nullability for ref project