Remove unused locals in System.ServiceProcess.ServiceController #31704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Feb 4, 2020
| @@ -474,7 +474,7 @@ private void DeferredPowerEvent(int eventType, IntPtr eventData) | |||
| try | |||
| { | |||
| PowerBroadcastStatus status = (PowerBroadcastStatus)eventType; | |||
| bool statusResult = OnPowerEvent(status); | |||
| _ = OnPowerEvent(status); | |||
There was a problem hiding this comment.
This can just be:
OnPowerEvent((PowerBroadcastStatus)eventType);
stephentoub
reviewed
Feb 4, 2020
| @@ -473,8 +473,7 @@ private void DeferredPowerEvent(int eventType, IntPtr eventData) | |||
| // already been freed. | |||
| try | |||
| { | |||
| PowerBroadcastStatus status = (PowerBroadcastStatus)eventType; | |||
| _ = OnPowerEvent(status); | |||
| _ = OnPowerEvent((PowerBroadcastStatus)eventType); | |||
There was a problem hiding this comment.
Suggested change
| _ = OnPowerEvent((PowerBroadcastStatus)eventType); | |
| OnPowerEvent((PowerBroadcastStatus)eventType); |
There was a problem hiding this comment.
When would you prefer discards?
There was a problem hiding this comment.
When would you prefer discards?
For ignored return values, only if it's critical that someone reading the code understands data is being thrown away, or if the compiler complains. The former might show up in one of our security libraries, for example. The latter might show up with a method returning a Task in an async method and where we explicitly want to ignore it.
Co-Authored-By: Stephen Toub <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #30457