[armel/Linux] Fix armel build #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option '-DARM_SOFTFP' not passed after dotnet#27077 which required for armel build. This commit fix it.
jkoritzinsky
approved these changes
Jan 10, 2020
am11
reviewed
Jan 12, 2020
eng/native/gen-buildsys.sh
Outdated
| @@ -167,6 +167,10 @@ if [ "$CROSSCOMPILE" == "1" ]; then | |||
| cmake_extra_defines="$cmake_extra_defines -DCMAKE_TOOLCHAIN_FILE=$scriptroot/../common/cross/toolchain.cmake" | |||
| fi | |||
|
|
|||
| if [ "$build_arch" == "armel" ]; then | |||
| cmake_extra_defines="$cmake_extra_defines -DARM_SOFTFP=1" | |||
There was a problem hiding this comment.
nit: this file is using 4-space indentation.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as dotnet/coreclr#27956
cc @jkotas