Move most of CoreLib interop under Common #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to #1232
jkotas
commented
Jan 2, 2020
src/libraries/System.IO.FileSystem.AccessControl/src/System.IO.FileSystem.AccessControl.csproj
Show resolved
Hide resolved
jkotas
commented
Jan 2, 2020
danmoseley
approved these changes
Jan 2, 2020
There was a problem hiding this comment.
Would it make sense for 100% of our interop files to be in this one location even if they are not shared?
Hmm, the extern declarations that aren't already in common, corelib, or tests are below. Mostly these are either not of general interest, or in legacy libraries we don't want to disturb. So not worth modifying them.
System.Data.OleDb\src\NativeMethods.cs
System.Data.OleDb\src\SafeNativeMethods.cs
System.Data.OleDb\src\UnsafeNativeMethods.cs
System.Data.SqlClient\src\Interop\SNINativeMethodWrapper.Windows.cs
System.Diagnostics.EventLog\src\System\Diagnostics\Reader\UnsafeNativeMethods.cs
System.DirectoryServices\src\Interop\SafeNativeMethods.cs
System.DirectoryServices\src\Interop\UnsafeNativeMethods.cs
System.DirectoryServices\src\System\DirectoryServices\ActiveDirectory\NativeMethods.cs
System.DirectoryServices\src\System\DirectoryServices\ActiveDirectory\UnsafeNativeMethods.cs
System.DirectoryServices.AccountManagement\src\System\DirectoryServices\AccountManagement\interopt.cs
System.DirectoryServices.Protocols\src\System\DirectoryServices\Protocols\ldap\Wldap32UnsafeMethods.cs
System.Drawing.Common\src\System\Drawing\Gdiplus.cs
System.Drawing.Common\src\System\Drawing\GdiplusNative.cs
System.Drawing.Common\src\System\Drawing\GdiplusNative.Unix.cs
System.Drawing.Common\src\System\Drawing\GdiplusNative.Windows.cs
System.Drawing.Common\src\System\Drawing\Icon.Windows.cs
System.Drawing.Common\src\System\Drawing\Image.cs
System.Drawing.Common\src\System\Drawing\LibX11Functions.cs
System.Drawing.Common\src\System\Drawing\macFunctions.cs
System.Drawing.Common\src\System\Drawing\Printing\LibcupsNative.cs
System.Drawing.Common\src\System\Drawing\UnsafeNativeMethods.cs
System.IO.Ports\src\Interop\Unix\Interop.Serial.cs
System.IO.Ports\src\Interop\Unix\Interop.Termios.cs
System.Security.Cryptography.Pkcs\src\Interop\Windows\Crypt32\Interop.CertDuplicateCertificateContext.cs
System.Security.Cryptography.X509Certificates\src\Internal\Cryptography\Pal.Windows\Native\Interop.crypt32.cs
System.Security.Cryptography.X509Certificates\src\Internal\Cryptography\Pal.Windows\Native\Interop.cryptoapi.cs
[edited to make sense]
We have several issues tracking the reformatting these (e.g. https://github.com/dotnet/corefx/issues/1739). As you have pointed out, it is not clear whether it is an improvement to have the definitions of domain specific APIs that are used just once under Common and split them into many little files. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1232