Optimize AdjustMaxWorkersActive #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ninedan reported this function as expensive in one of the server scenarios he monitors. The actual time is spent in `ThreadStore::GetAllThreadList`. Moving the call to `GetTotalWorkerThreadPoolCompletionCount` should reduce this cost. Fixes dotnet#1079
billwert
force-pushed
the
move-thread-computation
branch
from
491ff9f to
d7faed4
Compare
|
The failures don't look related to what I've done, but I'm not a contributor here so I don't think I can re-run them. |
|
I hit retry, I think. If you don't have the power, we should fix that |
kouvel
approved these changes
Jan 2, 2020
stephentoub
approved these changes
Jan 6, 2020
|
Hello @stephentoub! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
kouvel
added a commit
to kouvel/runtime
that referenced
this pull request
Oct 20, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ninedan reported this function as expensive in one of the server scenarios
he monitors. The actual time is spent in
ThreadStore::GetAllThreadList.Moving the call to
GetTotalWorkerThreadPoolCompletionCountshould reduce thiscost.
(This trace is from .NET Framework, but the code is similar and still calls
ThreadStore::GetAllThreadListin .NET Core)Fixes #1079