-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TensorPrimitives
XML docs: MinNumber
/ReciprocalSqrt
/ReciprocalSqrtEstimate
oversights
#109889
Conversation
They ware accidentally referring to maxima
The effective code was copied from the other reciprocal
Tagging subscribers to this area: @dotnet/area-system-numerics |
@dotnet-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@jeffhandley, @gewarren, I believe for this library the XML comments are the source of truth. Do we still need to submit a PR separately to dotnet-api-docs? Do we backport this to release/9.0 and then the "right things" happen? Something else? |
/ba-g comment change only |
Tagging @carlossanlop for the answer on this. |
Nope. Not if source of truth is triple slash comments as mentioned.
Yes. This needs to be backported to release/9.0-staging and the fixed docs should start showing up on the next servicing release. |
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11893607914 |
While going through the docs for
TensorPrimitives
I noticed some copy–paste accidents:MinNumber
refers to maxima instead of minimaReciprocalSqrt
andReciprocalSqrtEstimate
are missing the square root in the explanation of the effective computationI cross-checked IEEE754:2019 to make sure that the now referenced
minimumNumber
exists.Only XML doc comments are changed, no actual code.