Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix missing analyzer warning for generics in containing type" #109520

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Nov 4, 2024

Reverts #109392 to see if it fixes timeouts in CLR_Tools_Tests.

It seems this change may have introduced timeouts in CLR_Tools_Tests that I failed to notice when marking the PR as green due to debugger test timeouts.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Nov 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Nov 4, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@sbomer sbomer requested review from jkotas and a team November 4, 2024 19:35
@sbomer
Copy link
Member Author

sbomer commented Nov 4, 2024

/ba-g "chrome-DebuggerTests timeout, #108078"

@sbomer sbomer merged commit 10af5e0 into main Nov 4, 2024
66 of 76 checks passed
sbomer added a commit to sbomer/runtime that referenced this pull request Nov 4, 2024
@akoeplinger akoeplinger deleted the revert-109392-genericContainingType branch November 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants