Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STJ.Nodes.JsonArray.Remove(All|Range) #109472

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Add STJ.Nodes.JsonArray.Remove(All|Range) #109472

merged 7 commits into from
Nov 7, 2024

Conversation

karakasa
Copy link
Contributor

@karakasa karakasa commented Nov 2, 2024 •
edited
Loading

Close #107962

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 2, 2024
@karakasa karakasa marked this pull request as ready for review November 2, 2024 07:29
@build-analysis build-analysis bot mentioned this pull request Nov 6, 2024
Open
3 tasks
@build-analysis build-analysis bot mentioned this pull request Nov 6, 2024
Open
3 tasks
@build-analysis build-analysis bot mentioned this pull request Nov 6, 2024
Open
eiriktsarpalis
eiriktsarpalis approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eiriktsarpalis eiriktsarpalis merged commit 386669e into dotnet:main Nov 7, 2024
83 checks passed
@karakasa karakasa deleted the issue-107962 branch November 7, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees
No one assigned
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add System.Text.Json.Nodes.JsonArray.Remove(All|Range)
3 participants
@karakasa @jasonmalinowski @eiriktsarpalis