Fix PKCS#12 to use SHA1 MAC #108825
Merged
Fix PKCS#12 to use SHA1 MAC #108825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp list |
This comment was marked as outdated.
This comment was marked as outdated.
vcsjones
force-pushed
the
fix-108815
branch
2 times, most recently
from
093a8d7
to
698c06c
Compare
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bartonjs
reviewed
Oct 14, 2024
bartonjs
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #108795 I re-encoded two PKCS#12 documents to use 3DES instead of RC2 so they work on platforms that do not have RC2 available. However, the MAC on the PKCS#12 also changed from SHA-1 to SHA-256. Older Windows 10 (pre 1703, I think) does not support SHA-2 algorithms for the MAC, so this puts it back to SHA-1.
In addition, the test failure output for this is not particularly helpful. This changes the test to preserve the original exception thrown instead of swallowing it and failing with "Is Windows 10".
Contributes to #108815.