-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up in importervectorization.cpp #108818
Conversation
@jakobbotsch @AndyAyersMS @dotnet/jit-contrib PTAL the changes are mainly in one function so I suggest reviewing it as a whole, e.g. here: runtime/src/coreclr/jit/importervectorization.cpp Lines 90 to 213 in 51a3337
This simplifies code along with some benefits (see description). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice clean up.
Btw I see that arm64 still uses bitwise ops instead of conditional compares. The conditional compares would likely be more dense.
I presume it's better if some other phase (morph/lower) converts to a whatever is better shape. So it can also handle users inputs with bitwise ops |
A small clean up in importervectorization.cpp:
Diffs