Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete UsePublishedCrossgen2 property #108693

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 9, 2024

It should not be necessary after #107772

@jkotas
Copy link
Member Author

jkotas commented Oct 9, 2024

/azp run runtime-coreclr crossgen2 outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2024

/azp run runtime-coreclr crossgen2 outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2024

/azp run runtime-coreclr crossgen2 outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2024

/azp run runtime-coreclr crossgen2 outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ivdiazsa ivdiazsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this Jan! Are these errors related to these changes?

* You intended to execute a .NET program, but dotnet-/__w/1/s/artifacts/bin/coreclr/linux.x64.Release/crossgen2/crossgen2.dll does not exist.

We can merge once we get these ones resolved or confirmed to be unrelated.

@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2024

Are these errors related to these changes?

Yes, these errors are related. I need to fix those before this can be merged.

@jkotas
Copy link
Member Author

jkotas commented Oct 11, 2024

/azp run runtime-coreclr crossgen2 outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Oct 11, 2024

/azp run runtime-coreclr crossgen2 outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas merged commit 10e3d01 into dotnet:main Oct 11, 2024
124 of 141 checks passed
@jkotas jkotas deleted the UsePublishedCrossgen2 branch October 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants