Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from 7 repositories #108636

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 8, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20241010.13
  • Date Produced: October 11, 2024 1:07:59 AM UTC
  • Commit: 1f220e48e5bc666e992b24f118a17e01ca316819
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-externals

  • Subscription: b4338da2-58ef-486c-5124-08dbb92a7ffc
  • Build: 20241016.1
  • Date Produced: October 16, 2024 1:29:31 PM UTC
  • Commit: d22c9e818d40d0b36874f8db31550b1ea7f66c72
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20241014.3
  • Date Produced: October 14, 2024 3:33:28 PM UTC
  • Commit: baa8afd986699ff57f1fc55b3cfecd0c15b692b5
  • Branch: refs/heads/dotnet/main

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20241014.1
  • Date Produced: October 14, 2024 4:50:15 PM UTC
  • Commit: 6adfbf90867a7479319e54a9667eb94dc83c0267
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20241014.1
  • Date Produced: October 14, 2024 3:05:49 PM UTC
  • Commit: 3f3ab836c338d37ecdda238f630e81f1bbde7126
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20241015.1
  • Date Produced: October 15, 2024 10:26:51 PM UTC
  • Commit: e51bd3677d5674fa34bf5676c5fc5562206bf94e
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20241017.1
  • Date Produced: October 17, 2024 11:58:22 AM UTC
  • Commit: 2830cf5
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)
    • runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools: from 19.1.0-alpha.1.24501.1 to 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport)

Microsoft.DotNet.ApiCompat.Task
 From Version 10.0.100-alpha.1.24480.5 -> To Version 10.0.100-alpha.1.24507.16
…nals build 20241007.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 10.0.0-alpha.1.24502.3 -> To Version 10.0.0-alpha.1.24507.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/sdk [main] Update dependencies from dotnet/sdk, dotnet/source-build-externals Oct 8, 2024
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 10.0.0-alpha.1.24503.1 -> To Version 10.0.0-alpha.1.24507.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/sdk, dotnet/source-build-externals [main] Update dependencies from dotnet/icu, dotnet/sdk, dotnet/source-build-externals Oct 9, 2024
…ld 20241007.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 10.0.0-beta.24480.2 -> To Version 10.0.0-beta.24507.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/icu, dotnet/sdk, dotnet/source-build-externals [main] Update dependencies from dotnet/icu, dotnet/runtime-assets, dotnet/sdk, dotnet/source-build-externals Oct 10, 2024
…ild 20241007.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 10.0.0-alpha.0.24480.1 -> To Version 10.0.0-alpha.0.24507.1
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 10.0.0-alpha.1.24507.2 -> To Version 10.0.0-alpha.1.24510.1
…ld 20241010.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 10.0.0-beta.24507.1 -> To Version 10.0.0-beta.24510.1
…ild 20241010.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 10.0.0-alpha.0.24507.1 -> To Version 10.0.0-alpha.0.24510.1
…10.1

Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
 From Version 0.11.5-alpha.24480.1 -> To Version 0.11.5-alpha.24510.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime-assets, dotnet/sdk, dotnet/source-build-externals [main] Update dependencies from dotnet/cecil, dotnet/hotreload-utils, dotnet/icu, dotnet/runtime-assets, dotnet/sdk, dotnet/source-build-externals Oct 11, 2024
…nals build 20241011.4

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 10.0.0-alpha.1.24507.2 -> To Version 10.0.0-alpha.1.24511.4
…1011.14

Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24504.10 -> To Version 10.0.0-alpha.1.24511.14
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/cecil, dotnet/hotreload-utils, dotnet/icu, dotnet/runtime-assets, dotnet/sdk, dotnet/source-build-externals [main] Update dependencies from 7 repositories Oct 14, 2024
Microsoft.DotNet.ApiCompat.Task
 From Version 10.0.100-alpha.1.24507.16 -> To Version 10.0.100-alpha.1.24510.13
lewing and others added 11 commits October 15, 2024 03:17
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 10.0.0-alpha.1.24510.1 -> To Version 10.0.0-alpha.1.24514.3

Dependency coherency updates

runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 19.1.0-alpha.1.24501.1 -> To Version 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
…ld 20241014.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 10.0.0-beta.24510.1 -> To Version 10.0.0-beta.24514.1
…ild 20241014.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 10.0.0-alpha.0.24510.1 -> To Version 10.0.0-alpha.0.24514.1
…14.1

Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
 From Version 0.11.5-alpha.24510.1 -> To Version 0.11.5-alpha.24514.1
…nals build 20241014.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 10.0.0-alpha.1.24511.4 -> To Version 10.0.0-alpha.1.24514.2
…15.1

Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
 From Version 0.11.5-alpha.24514.1 -> To Version 0.11.5-alpha.24515.1
…nals build 20241015.3

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 10.0.0-alpha.1.24514.2 -> To Version 10.0.0-alpha.1.24515.3
…nals build 20241016.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 10.0.0-alpha.1.24515.3 -> To Version 10.0.0-alpha.1.24516.1
…1017.1

Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24511.14 -> To Version 10.0.0-alpha.1.24517.1
@kg
Copy link
Member

kg commented Oct 17, 2024

This is failing with a "new prebuilt", Microsoft.DotNet.ApiCompat.Task.10.0.100-alpha.1.24510.13, but I see Microsoft.DotNet.ApiCompat.Task in Version.Details.xml on main already. https://github.com/dotnet/source-build/blob/main/Documentation/eliminating-pre-builts.md doesn't specify what the correct resolution steps are for a version change - do we just bump the version in the .xml file? Or is that defeating the purpose of the prebuilt detection by creating an unresolved dependency?

<Uri>https://github.com/dotnet/sdk</Uri>
<Sha>9de571282093d76401a3f457a8e9f4427e088778</Sha>
<Sha>1f220e48e5bc666e992b24f118a17e01ca316819</Sha>
</Dependency>
<!-- Intermediate is necessary for source build. -->
<Dependency Name="Microsoft.SourceBuild.Intermediate.sdk" Version="10.0.100-alpha.1.24480.5">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package version also needs to get updated. It needs to be in sync with and other dotnet/sdk dependencies in this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to manually update the Sha too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the ApiCompat.Task version and sha upgrade are the ones that need to be downgraded as for whatever reason, there is not a newer Microsoft.SourceBuild.Intermediate.sdk package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will downgrade those and then strip NO-MERGE.

Update Microsoft.SourceBuild.Intermediate.sdk version to match other dotnet/sdk dependencies
@kg kg added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 17, 2024
Update the SHA too
Downgrade ApiCompat.Task instead.
Downgrade ApiCompatTaskVersion as well
@kg kg removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 17, 2024
@kg
Copy link
Member

kg commented Oct 17, 2024

The Pri0 Runtime Tests Run windows JIT test failures look real, but I'm not sure what could have caused them and why it only seems to be the windows lanes.

@steveisok
Copy link
Member

The Pri0 Runtime Tests Run windows JIT test failures look real, but I'm not sure what could have caused them and why it only seems to be the windows lanes.

Agreed... It seems most of the runtime tests are failing with something like:

System.BadImageFormatException: Bad IL format. The format of the file 'C:hwA7B20915wA16D08B5eJITjit64mccinteropmcc_i06mcc_i06.dll' is invalid.

@akoeplinger
Copy link
Member

@kg This could be due to changes to ilasm as these are IL-based tests, maybe related to 2b4e823?

@kg
Copy link
Member

kg commented Oct 19, 2024

@kg This could be due to changes to ilasm as these are IL-based tests, maybe related to 2b4e823?

It appears to happen when ilasm flows (I reproduced it locally), but the "corrupt" DLL files are not corrupt according to peverify, ilverify, ilspy, or ildasm. It seems like it might be a latent bug in the IL verifier in coreclr (that is only enabled in checked builds). I'm not sure why ilasm's behavior changed though, I've verified manually that none of the new behavior I added should be engaged (it's off by default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants