Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][debugging][release/9.0] Removed trailing command that results in a warning #108584

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[browser][debugging][release/9.0] Removed trailing command that results in a warning #108584

merged 1 commit into from
Oct 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 7, 2024 •
edited by maraf
Loading

Backport of #108583 to release/9.0

/cc @pavelsavara @dlemstra

Customer Impact

  • Customer reported
  • Found internally

Reported in PR #108583. It doesn't break anything, but produces a warning in editors for invalid JSON (but library used in VS tolerates it)

Regression

  • Yes

Introduced in #95392

Testing

Verified manually.

Risk

Low, just warning

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 7, 2024
@pavelsavara pavelsavara changed the title [release/9.0] Removed trailing command that results in a warning [browser][debugging][release/9.0] Removed trailing command that results in a warning Oct 7, 2024
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Debugger-mono os-browser Browser variant of arch-wasm labels Oct 7, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara added this to the 9.0.0 milestone Oct 7, 2024
@pavelsavara pavelsavara removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 7, 2024
lewing
lewing approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@lewing lewing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fundamentals

@lewing lewing added the Servicing-consider Issue for next servicing release review label Oct 8, 2024
jeffschwMSFT
jeffschwMSFT approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can treat this as tell mode.

cc @carlossanlop

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 8, 2024
@lewing lewing merged commit 24cfc7c into release/9.0 Oct 9, 2024
23 of 38 checks passed
@lewing lewing deleted the backport/pr-108583-to-release/9.0 branch October 9, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara pavelsavara approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@thaystg thaystg Awaiting requested review from thaystg

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Debugger-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lewing @pavelsavara @jeffschwMSFT @maraf @dlemstra