Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] [Swift interop] Fix InlineArray lowering with static fields #108546

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

jkurdek
Copy link
Member

@jkurdek jkurdek commented Oct 4, 2024

When lowering InlineArray the first field was fetched. This caused problems when the first field was a static field. Added logic which fetches first non-static field.

Fixes #108522

@jkurdek
Copy link
Member Author

jkurdek commented Oct 7, 2024

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkurdek
Copy link
Member Author

jkurdek commented Oct 7, 2024

/ba-g known test failures, unrelated to changes

@jkurdek jkurdek merged commit a859aa6 into dotnet:main Oct 7, 2024
121 of 128 checks passed
@jkurdek jkurdek deleted the fix/inline-array-static-fields branch October 7, 2024 17:35
sirntar pushed a commit to sirntar/runtime that referenced this pull request Oct 8, 2024
@jkurdek
Copy link
Member Author

jkurdek commented Oct 8, 2024

/backport to release/9.0

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11232214089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono] Fix swift lowering for InlineArray when static field occurs before instance field
3 participants