Fix statics issue by using data dependencies #108309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
This will fix the specific crash, but I do not think it is the 100% correct fix for the problem. Our memory model guarantees that all static constructor side-effects are observable. I think that this fix only guarantees visibility of observable side-effects for statics of the given type. |
This was also discussed in #81151 (comment) . #105832 added the barriers to JITed code, but we have missed that the barriers need to be in the asm and JIT helpers as well. |
3 tasks
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A data dependency approach for fixing issue #105441