-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Change ICU WasmBuildTests
to use wasmconsole
and wasmbrowser
templates
#108271
Merged
ilonatommy
merged 11 commits into
dotnet:main
from
ilonatommy:icu-wbt-should-use-templates
Sep 27, 2024
Merged
[wasm] Change ICU WasmBuildTests
to use wasmconsole
and wasmbrowser
templates
#108271
ilonatommy
merged 11 commits into
dotnet:main
from
ilonatommy:icu-wbt-should-use-templates
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2024
maraf
approved these changes
Sep 26, 2024
Tagging subscribers to 'arch-wasm': @lewing |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…ser` templates (dotnet#108271) * Clean up icu tests (automatic mode). * Block the failing test, mark problems with issue links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WasmTemplateTests
).WasmTemplateTests
was useful to be reused with other tests, so it got moved toWasmTemplateTestsBase
that will be a base class for all the other WBT that will be transformed to template-based.PredefinedIcudt
toCustomIcuFile
- it describes better what we're doing. This is not a public name.issues discovered - to be addressed in a follow-up PR, this one is already big enough. They are all connected with transition from
WasmAppBuilder
toWasm SDK
:NonExistingCustomFileAssertError
. wasmconsole should start using wasm sdk and drop WasmAppBuilder: [browser] Migratewasmconsole
template to WebAssembly SDK #102743.WasmIcuDataFileName
but works withBlazorIcuDataFileName
. While the functionality is preserved, the naming does not make sense - it's not a blazor app. Similar withWasmIncludeFullIcuData
vsBlazorWebAssemblyLoadAllGlobalizationData
. It will be fixed by [browser] Replace "blazor" prefix with "wasm" for common MSBuild properties #94133.CustomIcuShard
fails forisOnlyPredefinedCultures = true
withwasmbrowser
- blazor does not throw onisOnlyPredefinedCultures = true
, issue: [browser]OnlyPredefinedCultures=true
does not throw an exception when culture is missing #108272