Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] [aot] mono_aot_split_options: reset state after a backslash #108212

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 24, 2024

Backport of #108067 to release/9.0

/cc @lambdageek

Customer Impact

  • Customer reported
  • Found internally

Customers targeting WebAssembly, Android or iOS with projects in a directory containing a " may run into crashes or errors during AOT compilation.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Manual testing

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Sep 24, 2024
@lambdageek lambdageek added this to the 9.0.0 milestone Sep 24, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 9 GA

@lambdageek lambdageek self-assigned this Sep 24, 2024
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 2, 2024
@jeffschwMSFT jeffschwMSFT merged commit 3812e13 into release/9.0 Oct 3, 2024
10 checks passed
@jkotas jkotas deleted the backport/pr-108067-to-release/9.0 branch October 10, 2024 08:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Codegen-AOT-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants