[release/9.0] [browser] Fix fingerprinting and loadAllSatelliteResources=true #108198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
maraf,
ilonatommy,
lewing and
pavelsavara
as code owners
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
lewing
approved these changes
Sep 24, 2024
rbhanda
added
Servicing-approved
This was referenced Sep 24, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108190 to release/9.0
/cc @maraf
Customer Impact
If the parameter is specified, satellite assemblies are loaded through a different code path. This path wasn't updated when asset fingerprinting was introduced. Reported in #107742.
Regression
Regression introduced in #103755.
Testing
Automatic test. It is a rarely used feature and we didn't have covered it with test in combination with fingerprinting.
Risk
Low. The changed code path is used only when parameter is explicitly specified.