-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] disable debugger tests on CI #108178
Merged
pavelsavara
merged 3 commits into
dotnet:main
from
pavelsavara:browser_disable_debugger_tests
Nov 19, 2024
Merged
[browser] disable debugger tests on CI #108178
pavelsavara
merged 3 commits into
dotnet:main
from
pavelsavara:browser_disable_debugger_tests
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
area-Debugger-mono
os-browser
Browser variant of arch-wasm
labels
Sep 24, 2024
This was referenced Sep 24, 2024
Open
This was referenced Sep 26, 2024
@thaystg what should we do here? |
@lewing I am just back from vacation. I disagree about disabling all the tests while they are not enabled somewhere else. Can't we only disable the ones that are failing? |
Nobody attended them for months |
@thaystg do you have ETA ? |
# Conflicts: # eng/testing/tests.browser.targets # src/libraries/sendtohelix-browser.targets
This was referenced Nov 18, 2024
pavelsavara
requested review from
akoeplinger,
thaystg and
ilonatommy
as code owners
November 18, 2024 17:14
lewing
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable browser debugger tests on CI
Related
#106376
#98086
#89909
#89409
#86496
#52102