[release/9.0] [ILStrip] Fix passing assemblies using relative path #107548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
needs-area-label
jkurdek
added
area-Infrastructure-mono
os-ios
|
Tagging subscribers to this area: @directhex, @matouskozak |
rolfbjarne
approved these changes
Sep 9, 2024
vitek-karas
approved these changes
Sep 10, 2024
|
CC @jeffschwMSFT. |
jeffschwMSFT
approved these changes
Sep 11, 2024
|
@carlossanlop, it is ready to merge. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107536 to release/9.0
/cc @jkurdek
Customer Impact
#101967 Customer experienced compilation errors when referencing Cosmos DB nuget. Referencing this nuget caused unmanaged dlls to be referenced and passed to the ILStrip task which then crashed.
#106267 allowed ILStrip to gracefully handle (skip) unmanaged assemblies. Part of the fix included surfacing a new task output UpdatedAssemblies. This output is intended to be used by xamarin-macios in its MobileILStrip task.
While completing the fix on xamarin-macios side we have discovered that the UpdatedAssemblies output is not populated when assemblies are passed using relative paths, which caused some of the xamarin-macios tests to fail. This PR solves this issue. The fix is structured in a way to only affect the scenario enabled by #106267. It should not have any effect on other ILStrip applications.
Regression
Testing
The output is only to be used by xamarin-macios. The changes were verified locally by injecting a dll containing modified ILStrip into xamarin-macios.
Risk
(Very) Low. This change only affects
UpdatedAssembliesoutput which is currently not used forStripAssembliespath anywhere.