[cdac] Fix getting array function type in RuntimeTypeSystem.IsArrayMethod #106512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elinor-fung
commented
Aug 15, 2024
•
elinor-fung
commented
- Array method index should be the slot minus the number of virtuals, not the number of slots
- Constructor index should include 3, not just greater than
elinor-fung
requested review from
lambdageek,
davidwrighton and
AaronRobinsonMSFT
|
Tagging subscribers to this area: @tommcdon |
src/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.cs
Outdated
Show resolved
Hide resolved
lambdageek
reviewed
Aug 15, 2024
src/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.