Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Fix logging formatting #106367

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Aug 13, 2024

Backport of #106283 to release/8.0-dtaging

/cc @tarekgh

Customer Impact

Users of the .NET logging system may encounter incorrect log entries when attempting to log more than one collection argument. Instead of logging the individual values of the collection, the type name of the collection is logged. Examples of this issue can be found at #103338.

This is a regression in .NET 8.0

Details

We had some performance improvements in the logging formatting code that caused this regression.

Testing

Passed the regression tests and added more tests to cover the failing cases.

Risk

Low. This change only addresses the broken cases in the logging formatting code. It doesn't alter any logic; it simply ensures that collection formatting is corrected.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.
  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added this to the 8.0.x milestone Aug 13, 2024
@tarekgh tarekgh added the Servicing-consider Issue for next servicing release review label Aug 13, 2024
@tarekgh
Copy link
Member Author

tarekgh commented Aug 13, 2024

CC @ericstj @artl93

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 20, 2024
@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.10 Aug 20, 2024
@tarekgh tarekgh merged commit eda809d into dotnet:release/8.0-staging Aug 25, 2024
110 of 113 checks passed
@ergunr
Copy link

ergunr commented Aug 25, 2024 via email

@tarekgh
Copy link
Member Author

tarekgh commented Aug 25, 2024

@ergunr are you trying to communicate something on this change?

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants