Fix: SettingsProperty constructor ignores serializeAs parameter if it is not SettingsSerializeAs.Binary #106295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not SettingsSerializeAs.Binary
This was referenced Aug 13, 2024
steveharter
reviewed
Aug 13, 2024
...ystem.Configuration.ConfigurationManager/tests/System/Configuration/SettingsPropertyTests.cs
Outdated
Show resolved
Hide resolved
steveharter
approved these changes
Aug 13, 2024
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue the
SettingsPropertyconstructor ignoresserializeAsparameter if it is notSettingsSerializeAs.Binary, the regression caused by #50531 which allowsBinaryFormatterserialization only when anAppContextswitch:System.Configuration.ConfigurationManager.EnableUnsafeBinaryFormatterInPropertyValueSerializationis set, and throws otherwise.The current fix is setting the
SerializeAsproperty with theserializeAsparameter when it is notSettingsSerializeAs.Binary, though we might want to remove theAppContextswitch logic and throw forSettingsSerializeAs.Binaryas now theBinaryFormatteris removed and accessing the property values throwsPlatformNotSupportedExceptionon serialization even if the switch is on. The related testSerializeAndDeserializeWithSettingsSerializeAsBinarynow throws PNSE on VS, skipped when run from command line.Fixes #104732