Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround EventSource counters race condition in networking tests #106294

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

MihaZupan
Copy link
Member

Fixes #106268
See #106268 (comment)

Since some IncrementingPollingCounter data may be dropped from the first reported increment, this change ensures that the background timer thread is running before executing the actual test code.

Updated our Http and Security tests as those are the only ones using an IncrementingPollingCounter.

@MihaZupan
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MihaZupan
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MihaZupan MihaZupan merged commit 6a69493 into dotnet:main Aug 13, 2024
84 of 92 checks passed
@karelz karelz added this to the 9.0.0 milestone Sep 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test Failure] EventSource_SendingRequest_PathAndQueryRedaction_LogsStartStop
4 participants