Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Be more cautious about page zeroing #106080

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[wasm] Be more cautious about page zeroing #106080

merged 1 commit into from
Aug 8, 2024

Conversation

kg
Copy link
Member

@kg kg commented Aug 7, 2024

Should fix #106007

@kg kg added the arch-wasm WebAssembly architecture label Aug 7, 2024
@@ -125,7 +125,7 @@ static unsigned long
prot_flags_for_activate (int activate)
{
unsigned long prot_flags = activate? MONO_MMAP_READ|MONO_MMAP_WRITE: MONO_MMAP_NONE;
return prot_flags | MONO_MMAP_PRIVATE | MONO_MMAP_ANON | MONO_MMAP_NOZERO;
return prot_flags | MONO_MMAP_PRIVATE | MONO_MMAP_ANON;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should some of this be ifdef WASM ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It currently has no effect on other platforms, so it doesn't need to be

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-GC-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono][wasm] Assertion at mono/utils/lock-free-alloc.c:210, condition `!desc->in_use' not met
3 participants