Don't hit all properties on Color in ColorTranslator #106042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnownColor based Color values look up the value with every method/property access. Avoid this by making Color.GetRgbValues internal and use it in ColorTranslator. This is more of a hit in Windows where system colors also involve a system call. Fixes dotnet#105992
stephentoub
approved these changes
Aug 6, 2024
This was referenced Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KnownColor based Color values look up the value with every method/property access. Avoid this by making Color.GetRgbValues internal and use it in ColorTranslator.
This is more of a hit in Windows where system colors also involve a system call.
Fixes #105992