[DRAFT] Add Keep-Alive Ping and Timeout implementation #105672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 30, 2024
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 30, 2024
|
For history: The weird hang happened (flaky) on linux mono minijit or interpreter with Debug libraries test: we cancel CloseAsync and expect the cancellation to abort the websocket (so it will surface in awaiting the read task) Task receiveTask = cws.ReceiveAsync(new byte[1], testTimeoutCts.Token);
var cancelCloseCts = new CancellationTokenSource();
await Assert.ThrowsAnyAsync<OperationCanceledException>(async () =>
{
Task t = cws.CloseAsync(WebSocketCloseStatus.NormalClosure, null, cancelCloseCts.Token);
cancelCloseCts.Cancel();
await t;
});
await Assert.ThrowsAnyAsync<OperationCanceledException>(() => receiveTask);code in question (simplified): private async Task CloseAsyncPrivate(...)
{
Log.CloseAsyncPrivateStarted();
try
{
//...
await SendCloseFrameAsync(...);
//...
Log("Waiting for a close frame");
//...
CancellationTokenRegistration registration = default;
try
{
if (cancellationToken.CanBeCanceled)
{
Log("Registering for cancellation");
registration = cancellationToken.Register(static s =>
{
Log("Aborting due to cancellation");
((ManagedWebSocket)s!).Abort();
}, this);
}
//...
Log("Waiting for the _receiveMutex...");
await _receiveMutex.EnterAsync(cancellationToken); // this one ends up throwing TCE
// ...
}
finally
{
// ...
Log("Disposing cancellation registration");
registration.Dispose();
Log("Cancellation registration disposed");
}
}
//...
}
catch (Exception exc)
{
Log.Exception(exc);
throw;
}
finally
{
Log.CloseAsyncPrivateCompleted();
}
}logs: Note: 13:31:51 is when TCE happens, but Abort only starts at 13:32:21 Full trace |
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description TBA
ClientWebSocket tests TBA
[UPD 7/30] Existing WebSocket microbenchmarks (keep-alive disabled):