Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a constant node for Vector64 #105538

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Don't create a constant node for Vector64 #105538

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
789917a
Don't create a constant node for Vector64
tannergooding Jul 26, 2024
1c9a79c
Ensure we process all arguments so the some_const case is correct
tannergooding Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,14 +1342,16 @@ emit_vector_create_elementwise (
// optimizations can be enabled. This includes recognizing partial constants
// and only performing the minimal number of inserts required

gboolean all_const = true;
gboolean all_const = false;
gboolean some_const = false;

guint8 cns_vec[16];
memset (cns_vec, 0x00, 16);

int vector_size = mono_class_value_size (vklass, NULL);
if (vector_size == 16) {
all_const = true;

for (int i = 0; i < param_count; ++i) {
if (!is_const (args[i])) {
all_const = false;
Expand Down
Loading