-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from 8 repositories #104856
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
a930a6f
Update dependencies from https://github.com/dotnet/icu build 20240712.1
dotnet-maestro[bot] 6e5c1b4
Update dependencies from https://github.com/dotnet/icu build 20240712.1
dotnet-maestro[bot] 3af0738
Update dependencies from https://github.com/dotnet/icu build 20240712.1
dotnet-maestro[bot] e3e98b5
Update dependencies from https://github.com/dotnet/runtime build 2024…
dotnet-maestro[bot] 78755d7
Update dependencies from https://github.com/dotnet/sdk build 20240715.8
dotnet-maestro[bot] 9130d9e
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] e4b7e6f
Merge branch 'main' into darc-main-d40a1612-0086-41b5-bd8f-524ea06f0bac
akoeplinger 37a730b
Dependency coherency updates
dotnet-maestro[bot] 182f722
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] fa59a42
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] e0a1893
Update dependencies from https://github.com/dotnet/cecil build 202407…
dotnet-maestro[bot] 5170317
Dependency coherency updates
dotnet-maestro[bot] 58aa801
Update dependencies from https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] 93f75cb
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] 0af0897
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] 1251b3f
Update dependencies from https://github.com/dotnet/cecil build 202407…
dotnet-maestro[bot] dac3d9d
Dependency coherency updates
dotnet-maestro[bot] ac44661
Update dependencies from https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] 50e1080
Revert "Dependency coherency updates"
radekdoulik 384a451
Remove llvm coherency deps
radekdoulik 47ba28e
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] 92545b4
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] 46a6d28
Update dependencies from https://github.com/dotnet/cecil build 202407…
dotnet-maestro[bot] ccc89a9
Update dependencies from https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] b169b7c
Merge branch 'main' into darc-main-d40a1612-0086-41b5-bd8f-524ea06f0bac
lewing 27c3112
Update dependencies from https://github.com/dotnet/sdk build 20240718.3
dotnet-maestro[bot] 2eca697
WBT: Install manifest into versioned sub folder
maraf 9fa1f6f
Roll back llvm to 16
lewing fdc142b
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] ac719fd
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] 1f99709
Update dependencies from https://github.com/dotnet/cecil build 202407…
dotnet-maestro[bot] 9acecb1
Update dependencies from https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] d31aa22
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] 47222d9
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] de6cdbf
Update dependencies from https://github.com/dotnet/cecil build 202407…
dotnet-maestro[bot] cf41c42
Update dependencies from https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] bb3a246
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] 9c40414
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] b28a139
Update dependencies from https://github.com/dotnet/cecil build 202407…
dotnet-maestro[bot] 212dd90
Update dependencies from https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] 15e6bf6
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] 48a6767
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] ab7c52a
Update dependencies from https://github.com/dotnet/cecil build 202407…
dotnet-maestro[bot] 58e87f2
Update dependencies from https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] 90b4daa
Update dependencies from https://github.com/dotnet/runtime build 2024…
dotnet-maestro[bot] 56e6527
Update dependencies from https://github.com/dotnet/sdk build 20240721.4
dotnet-maestro[bot] 726e5a2
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] 6d02472
Merge branch 'main' into darc-main-d40a1612-0086-41b5-bd8f-524ea06f0bac
lewing bbd7f35
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] c11409e
Merge branch 'main' into darc-main-d40a1612-0086-41b5-bd8f-524ea06f0bac
lewing 072fb10
Add repo local sbrp
lewing 94fe52e
Update SourceBuildPrebuiltBaseline.xml
lewing b036a91
Update SourceBuildPrebuiltBaseline.xml
lewing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect these packages are lifted during the product source-build therefore these versions are only being used during the repo's source-build leg. When working on dotnet/source-build-reference-packages#979, I ran a full product source build to ensure none of these were required.
Per https://github.com/dotnet/source-build-reference-packages?tab=readme-ov-file#adding-new-packages
Therefore it is correct to include these as allowed prebuilts but the reference to dotnet/source-build-reference-packages#979 is not the correct reason they are allowed here as previously mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelSimons I think @lewing is bringing up a valid point. Removing SBRP packages that aren't used in the full product build but are in the repo build will break dependency flow. Is there a way to better rollout or stage these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am open to suggestions on how to rollout these changes better. I try to limit this "cleanup" to just before we enter RC. I don't expect each repo will be affected by this change, it will only be a small subset.