Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure mono wasm jiterpreter handles v128_bitcast #104698

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Ensure mono wasm jiterpreter handles v128_bitcast #104698

merged 1 commit into from
Jul 12, 2024

Conversation

tannergooding
Copy link
Member

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 10, 2024
@tannergooding tannergooding added area-Codegen-Interpreter-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 10, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

@xtqqczze xtqqczze mentioned this pull request Jul 10, 2024
Open
This was referenced Jul 11, 2024
Open
Closed
@tannergooding tannergooding marked this pull request as ready for review July 11, 2024 15:49
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jul 11, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jul 11, 2024
@pavelsavara
Copy link
Member

The CI fail is #104737

@tannergooding
Copy link
Member Author

@BrzVlad, @kotlarmilos; could this get secondary sign-off. Simple change and should fix the perf regression that was identified

@build-analysis build-analysis bot mentioned this pull request Jul 11, 2024
Closed
@tannergooding tannergooding merged commit 07de38f into dotnet:main Jul 12, 2024
33 of 36 checks passed
@tannergooding tannergooding deleted the wasm-interp-vector-as branch July 12, 2024 13:34
@tannergooding tannergooding mentioned this pull request Jul 12, 2024
Open
@lewing lewing mentioned this pull request Jul 19, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@BrzVlad BrzVlad BrzVlad approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@tannergooding tannergooding

Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[Perf] Linux/x64: 71 Regressions on 7/2/2024 7:47:18 PM
4 participants
@tannergooding @pavelsavara @kg @BrzVlad