-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64/SVE: Implemented ConvertToint64
and ConvertToUInt64
#103502
Conversation
updating branch due to assert issue.
Note regarding the
|
1 similar comment
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
ConvertToint64
and ConvertToUInt64
@@ -78,6 +78,16 @@ | |||
} | |||
}"; | |||
|
|||
const string SimpleVecOpTest_ValidationLogicForCndSelForNarrowing = @"for (var i = 0; i < Op1ElementCount; i++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we rename this to SimpleVecOpTest_ValidationLogicForCndSelNarrowing
, and do the same for SimpleVecOpTest_ValidationLogicForNarrowing
so it's SimpleVecOpTest_ValidationLogicNarrowing
? We seem to use the Narrowing
suffix on its own elsewhere in the file, so this seems to be a bit more consistent.
Contributes to #99957
Stress test output:
cc @dotnet/arm64-contrib